Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[supervisor] Close docker unix socket on termination #5295

Merged
merged 1 commit into from
Aug 20, 2021
Merged

[supervisor] Close docker unix socket on termination #5295

merged 1 commit into from
Aug 20, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 20, 2021

No description provided.

@roboquat roboquat requested a review from mrsimonemms August 20, 2021 12:54
@aledbf
Copy link
Member Author

aledbf commented Aug 20, 2021

/assign @akosyakov

akosyakov
akosyakov approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat added the lgtm label Aug 20, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 481855b8e77b65b6e9cbdf15e162e44020e0920a

@akosyakov
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 20, 2021 •
edited
Loading

Codecov Report

Merging #5295 (1590234) into main (58f0b33) will increase coverage by 37.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5295       +/-   ##
=========================================
+ Coverage      0   37.59%   +37.59%     
=========================================
  Files         0       16       +16     
  Lines         0     4104     +4104     
=========================================
+ Hits          0     1543     +1543     
- Misses        0     2435     +2435     
- Partials      0      126      +126
Flag Coverage Δ
components-supervisor-app 37.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go 6.38% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/supervisor/pkg/ports/exposed-ports.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 25.50% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go 55.22% <0.00%> (ø)
...mponents/supervisor/pkg/supervisor/notification.go 83.95% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 76.00% <0.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go 45.65% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f0b33...1590234. Read the comment docs.

@roboquat roboquat merged commit 5bd688b into main Aug 20, 2021
@roboquat roboquat deleted the aledbf/ssh branch August 20, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@mrsimonemms mrsimonemms Awaiting requested review from mrsimonemms

Assignees

@akosyakov akosyakov

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @roboquat @akosyakov